[
https://issues.apache.org/jira/browse/SOLR-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651899#comment-17651899
]
David Smiley commented on SOLR-10467:
-------------------------------------
I SOLR-16061 (9.0), this setter moved off from CloudSolrClient, and thus I
think the mutability risk is lower. Someone would have to get the cluster
state provider and cast it then call a setter. Furthermore, setting this does
nothing once the ZkStateReader is lazy-initialized, basically as soon as you
really start using the SolrClient. Again, this reduces the mutability risk of
something bad happening. I think we should mark this as "Won't-Fix". WDYT
[~gerlowskija]?
> setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods
> ------------------------------------------------------------------------------
>
> Key: SOLR-10467
> URL: https://issues.apache.org/jira/browse/SOLR-10467
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 7.0
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the
> {{setZkConnectTimeout}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
