[
https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648168#comment-17648168
]
David Smiley commented on SOLR-14988:
-------------------------------------
In retrospect, renaming the method isn't necessary; its name is fine. A core
is loaded by virtue of having an instance of it :-) and that's what this method
returns. Note that the primary point of this JIRA issue is that this method
should return all loaded cores, (including those with isTransient=true). I
took a look at your PR and you didn't do that.
Note that there is work going on right now in SolrCores to refactor things so I
recommend just pausing this until that completes.
> CoreContainer.getCores should should return transient cores that are loaded
> ---------------------------------------------------------------------------
>
> Key: SOLR-14988
> URL: https://issues.apache.org/jira/browse/SOLR-14988
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CoreContainer.getCores() returns loaded SolrCores _except_ the transient
> ones. The callers of this method all assume it's all loaded cores, however.
> I think getCores should be renamed getLoadedCores for clarity as to _which_
> cores are being returned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
