[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645477#comment-17645477
]
Shawn Heisey commented on SOLR-9509:
------------------------------------
I love shellcheck. I do sometimes disable some of the "style" warnings because
I actually want the effect it mentions. I always run it on any shell script I
write, and I find that its recommendations are worth doing.
https://www.shellcheck.net/wiki/SC2029
> Fix problems in shell scripts reported by "shellcheck"
> ------------------------------------------------------
>
> Key: SOLR-9509
> URL: https://issues.apache.org/jira/browse/SOLR-9509
> Project: Solr
> Issue Type: Task
> Components: scripts and tools
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: newdev
> Attachments: SOLR-9509.patch, bin_solr_shellcheck.txt,
> shellcheck_solr_20160915.txt, shellcheck_solr_bin_bash_20160915.txt,
> shellcheck_solr_bin_sh_20160915.txt,
> shellcheck_solr_usr_bin_env_bash_20160915.txt
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Running {{shellcheck}} on our shell scripts reveal various improvements we
> should consider.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
