janhoy commented on PR #1168: URL: https://github.com/apache/solr/pull/1168#issuecomment-1344026969
Also, I'm wondering. Could we not let this module register itself as `GlobalTracer` if enabled? I mean, if you enable the module with `-Dsolr.modules=opentelemetry` then chances are you want to use it as well? It would relieve users from having to edit `solr.xml`. Alternatively we could gate this on the environment variable `OTEL_SDK_DISABLED`, so that if a user for some reason configures several tracer modules, or adds the Datadog agent, then setting `-Dotel.sdk.disabled=true` would prevent our module from registering as `GlobalTracer`. But I'd like that the experience for typical use should be as simple as possible. Add the module and configure it with env.vars/sysprops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
