[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643462#comment-17643462
]
Ishan Chattopadhyaya commented on SOLR-16347:
---------------------------------------------
bq. In terms of the veto, if you're not open to a compromise that'd hopefully
address both our concerns, then I guess I'll need to decide whether or not to
raise the issue with the PMC to determine whether there's "valid technical
justification" for the veto. I'm personally not convinced there is. (If I was
convinced I would've just "done the thing" long ago.).
The commits here have caused a performance degradation, as I have documented in
SOLR-16531. It is a valid technical justification for the veto.
bq. I guess I'll need to decide whether or not to raise the issue with the PMC
to determine whether there's "valid technical justification" for the veto.
I am a committer and PMC member and I'm invoking my right to veto these
commits. As per ASF guidelines, a vetoed commit must be reverted, preferably by
the original committer. Feel free to discuss this in any forum you feel
appropriate.
bq. relatively simple workarounds that don't require a complex revert (i.e.
-Ddisable.v2.api with the fix I suggested last week).
If you plan to disable by default an API endpoint (that works as of 9.1
release), I'll have to veto that as well.
> Add JAX-RS integration for defining v2 APIs
> -------------------------------------------
>
> Key: SOLR-16347
> URL: https://issues.apache.org/jira/browse/SOLR-16347
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: v2 API
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> SOLR-15182 rewrote our v2 APIs to use annotations using an existing
> (in-house) framework. But continuing to use a homegrown framework is less
> than ideal for a few reasons:
> # Our in-house framework doesn't integrate with 3rd-party tooling like
> OpenAPI.
> # It gives us less functionality than many off-the-shelf frameworks, at a
> higher maintenance cost.
> # The current framework is less explicit about API inputs and outputs than
> many off-the-shelf alternatives, making code less clear and readable for
> developers.
> (For more on the pros/cons and for different evaluations on the tradeoff
> here, see
> [this|https://lists.apache.org/thread/6wx2vzfnmfgkw03b7s450zfp7yhrlz8f]
> long-running dev@ thread.)
> The work done by SOLR-15182 makes the jump to JAX-RS reasonably
> straightforward on an individual API basis: once the framework is in place
> switching a given API to JAX-RS is mostly a matter of swapping out our
> homegrown annotations for those recognized by JAX-RS and changing API method
> signatures to better represent the API inputs/outputs.
> We should integrate Jersey or a similar JAX-RS implementation and start
> cutting over v2 APIs to this new mode of definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
