thomascorthals commented on code in PR #484:
URL: https://github.com/apache/solr/pull/484#discussion_r1030818857
##########
solr/server/solr/configsets/sample_techproducts_configs/conf/managed-schema:
##########
@@ -195,39 +195,35 @@
<!-- Dynamic field definitions allow using convention over configuration
- for fields via the specification of patterns to match field names.
- EXAMPLE: name="*_i" will match any field ending in _i (like myid_i,
z_i)
- RESTRICTION: the glob-like pattern in the name attribute must have
- a "*" only at the start or the end. -->
-
- <dynamicField name="*_i" type="pint" indexed="true" stored="true"/>
- <dynamicField name="*_is" type="pint" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_s" type="string" indexed="true" stored="true" />
- <dynamicField name="*_s_ns" type="string" indexed="true" stored="false"
/>
- <dynamicField name="*_ss" type="string" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_l" type="plong" indexed="true" stored="true"/>
- <dynamicField name="*_l_ns" type="plong" indexed="true" stored="false"/>
- <dynamicField name="*_ls" type="plong" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_t" type="text_general" indexed="true"
stored="true"/>
- <dynamicField name="*_txt" type="text_general" indexed="true"
stored="true" multiValued="true"/>
- <dynamicField name="*_en" type="text_en" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_b" type="boolean" indexed="true" stored="true"/>
- <dynamicField name="*_bs" type="boolean" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_f" type="pfloat" indexed="true" stored="true"/>
- <dynamicField name="*_fs" type="pfloat" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_d" type="pdouble" indexed="true" stored="true"/>
- <dynamicField name="*_ds" type="pdouble" indexed="true" stored="true"
multiValued="true"/>
-
+ for fields via the specification of patterns to match field names.
+ EXAMPLE: name="*_i" will match any field ending in _i (like myid_i, z_i)
+ RESTRICTION: the glob-like pattern in the name attribute must have a "*"
only at the start or the end. -->
+
+ <dynamicField name="*_i" type="pint" indexed="true" stored="true"/>
+ <dynamicField name="*_is" type="pints" indexed="true" stored="true"/>
+ <dynamicField name="*_s" type="string" indexed="true" stored="true" />
+ <dynamicField name="*_ss" type="strings" indexed="true" stored="true"/>
+ <dynamicField name="*_l" type="plong" indexed="true" stored="true"/>
+ <dynamicField name="*_ls" type="plongs" indexed="true" stored="true"/>
+ <dynamicField name="*_b" type="boolean" indexed="true" stored="true"/>
+ <dynamicField name="*_bs" type="booleans" indexed="true" stored="true"/>
+ <dynamicField name="*_f" type="pfloat" indexed="true" stored="true"/>
+ <dynamicField name="*_fs" type="pfloats" indexed="true" stored="true"/>
+ <dynamicField name="*_d" type="pdouble" indexed="true" stored="true"/>
+ <dynamicField name="*_ds" type="pdoubles" indexed="true" stored="true"/>
<dynamicField name="*_dt" type="pdate" indexed="true" stored="true"/>
- <dynamicField name="*_dts" type="pdate" indexed="true" stored="true"
multiValued="true"/>
- <dynamicField name="*_p" type="location" indexed="true" stored="true"/>
+ <dynamicField name="*_dts" type="pdates" indexed="true" stored="true"/>
+ <dynamicField name="*_t" type="text_general" indexed="true" stored="true"
multiValued="false"/>
+ <dynamicField name="*_txt" type="text_general" indexed="true"
stored="true"/>
- <dynamicField name="*_c" type="currency" indexed="true" stored="true"/>
+ <dynamicField name="random_*" type="random"/>
+ <dynamicField name="ignored_*" type="ignored"/>
- <dynamicField name="ignored_*" type="ignored" multiValued="true"/>
- <dynamicField name="attr_*" type="text_general" indexed="true"
stored="true" multiValued="true"/>
Review Comment:
Is this removal of `attr_*` intentional? I see it's still in the `_default`
config set. Will it be removed there as well?
Such changes trip up integration tests for a client library that run against
Solr 7, 8 and 9 with the same data. I'm trying to determine what's the
future-proof course of action here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
