ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1299774688
Lucerne’s BooleanQuery clauseSets is externally mutable. The getClauses method returns a mutable collection (hashset) so the caller might add to it. I don’t see an occurrence, but some unexpected inner mutability is an easy mistake. The idea in the related issue above of using `@Immutable` to assert deeply would be a nice goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
