risdenk commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1295006402
> I assume this is the PR that will stay in main branch, since there is no dependency added in solrj's build.gradle to depend on solrj-streaming? @janhoy yes - will add to branch_9x like solrj-zookeeper did - see https://github.com/apache/solr/pull/1099#issuecomment-1294043754. @dsmiley asked the same question on the Jira. > Should there not be some refguide docs in streaming about the need to add solrj-streaming as a dependency to your app if you need the IO classes? good catch will need to update. > I also assume there will be a backport PR that adds the transitive dependency from solrj to solrj-zookeeper, perhaps along with a note in the Upgrade Notes for 9.2 that you can now opt out of solrj-streaming on client if you don't use it, simply by excluding the coordinates in your POM. yup makes sense. > solrj/build.gradle shouldn't need hsqldb anymore; right? And it shouldn't depend on 'solr:modules:sql' if the corresponding tests have been moved. @joel-bernstein I can help take another look at the dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
