gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r1006078777
########## solr/core/src/java/org/apache/solr/handler/admin/api/RenameCollectionAPI.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.admin.api; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.api.PayloadObj; +import org.apache.solr.client.solrj.request.beans.RenameCollectionPayload; +import org.apache.solr.common.params.CollectionAdminParams; +import org.apache.solr.common.params.CollectionParams; +import org.apache.solr.handler.admin.CollectionsHandler; + +import java.util.HashMap; +import java.util.Locale; +import java.util.Map; + +import static org.apache.solr.client.solrj.SolrRequest.METHOD.POST; +import static org.apache.solr.handler.ClusterAPI.wrapParams; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_EDIT_PERM; + +@EndPoint( + path = {"/collections/{collection}"}, Review Comment: Can you be a little more specific about what part is unclear or that you're stuck on? The code snippet in your last comment looks generally 👌 at a glance, except that: 1. The last argument in your `wrapParams` call should be the value of the "target" parameter. We used Jackson to parse that into a payload instance just a few lines above, so we can fetch the target value from that payload instance (e.g. `v2Body.to`) 2. You should add `async` and `followAliases` to the `wrapParams` invocation, handling those similarly to "target". Happy to expand or clarify anything else as well, but you'll need to be a bit more specific what bit you're unclear on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
