[ 
https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624626#comment-17624626
 ] 

ASF subversion and git services commented on SOLR-16416:
--------------------------------------------------------

Commit a21e8bc4f3c3efcc94bb5a3d6bf76a4a562d3dd0 in solr's branch 
refs/heads/branch_9_1 from Houston Putman
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=a21e8bc4f3c ]

SOLR-16416: Fix testDesignatedOverseerRestarts

Remove roles for all nodes in reverse election order.
This will make sure no elections take place at the beginning of the
test, which can cause problems later on in the test.

(cherry picked from commit b01ae1783946b7fee43cd2faace0b721f7f7d29f)


> Fix silently failing Overseer Election joinAtHead during 
> testDesignatedOverseerRestarts
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-16416
>                 URL: https://issues.apache.org/jira/browse/SOLR-16416
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Houston Putman
>            Assignee: Houston Putman
>            Priority: Major
>             Fix For: 9.1, main (10.0)
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> OverseerRolesTest.testDesignatedOverseerRestarts has been failing 
> consistently (around 2.5% of the time). I think this is because 
> LeaderElection.joinElection does not respect the joinAtHead flag, if 
> connectionIssues happen while setting the leader election nodes.
> LeaderElection does not use the automatic retryOnConnLoss flags when doing zk 
> operations. Instead, it waits for an error to come back, and it handles the 
> retry itself. This is fine for the normal case, because it checks if node is 
> represented in the leaderElection child nodes, and if so it ignores the 
> connection loss. However when doing joinAtHead, if the childNode exists, but 
> isn't at the place it should be, then the manual retry should be exercised.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to