[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955: Update Jetty dependency to 10

[GitBox]

risdenk commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1002842535


##########
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java:
##########
@@ -452,9 +457,6 @@ public void lifeCycleFailure(LifeCycle arg0, Throwable 
arg1) {
     gzipHandler.setHandler(chain);
 
     gzipHandler.setMinGzipSize(23); // 
https://github.com/eclipse/jetty.project/issues/4191
-    gzipHandler.setCheckGzExists(false);
-    gzipHandler.setCompressionLevel(-1);
-    gzipHandler.setExcludedAgentPatterns(".*MSIE.6\\.0.*");

Review Comment:
   * `setCheckGzExists​(boolean checkGzExists)` - removed w/o replacement - 
https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/server/handler/gzip/GzipHandler.html#setCheckGzExists(boolean)
   * `setCompressionLevel` - removed from Jetty 10 - 
https://www.eclipse.org/jetty/javadoc/jetty-10/org/eclipse/jetty/server/handler/gzip/GzipHandler.html
   * `setExcludedAgentPatterns` - already includes MSIE 6 by default - see 
description here: 
https://www.eclipse.org/jetty/javadoc/jetty-10/org/eclipse/jetty/server/handler/gzip/GzipHandler.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org