[
https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619536#comment-17619536
]
ASF subversion and git services commented on SOLR-16300:
--------------------------------------------------------
Commit c4044f7e8153beddb545e47f851e760feefd4260 in solr's branch
refs/heads/branch_9x from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c4044f7e815 ]
SOLR-16300: migrate assert to non deprecated version (#947)
Co-authored-by: Kevin Risden <kris...@apache.org>
> Migrate from deprecated assertThat() to
> org.hamcrest.MatcherAssert.assertThat()
> -------------------------------------------------------------------------------
>
> Key: SOLR-16300
> URL: https://issues.apache.org/jira/browse/SOLR-16300
> Project: Solr
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 9.0, main (10.0)
> Reporter: Eric Pugh
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: main (10.0)
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> The org.junit.Assert that our unit tests all extend from indicates that
> assertThat() is deprecated, and to use
> org.hamcrest.MatcherAssert.assertThat() instead.
> We currently in our tests have both a mix of the assertThat() AND
> MatcherAssert.assertThat() methods...
> It *appears* that I can also just override the assertThat() method defined in
> org.junit.Assert in our base test classes to be one that calls out
> MatcherAssert.assertThat() which might let us change fewer lines of code..
> I'd love some direction from more experienced folks on what the right
> direction to go is!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
