[ https://issues.apache.org/jira/browse/SOLR-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618290#comment-17618290 ]
Shawn Heisey commented on SOLR-16432: ------------------------------------- I suspect, but haven't confirmed, that this failure running "./gradlew check" on Linux (also mentioned on SOLR-8803) is due to the gradle upgrade. {{> Task :solr:modules:hdfs:validateSourcePatterns FAILED tabs instead spaces: /home/elyograg/git/solr/solr/modules/hdfs/property 'outputLocation'/outputs/OUTPUT-org.apache.solr.hdfs.cloud.api.collections.TestHdfsCloudBackupRestore.txt}} > Upgrade the gradle wrapper to 7.5.1 > ----------------------------------- > > Key: SOLR-16432 > URL: https://issues.apache.org/jira/browse/SOLR-16432 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Build > Affects Versions: 9.0, 9.1 > Reporter: Shawn Heisey > Assignee: Kevin Risden > Priority: Minor > Fix For: main (10.0), 9.2 > > Attachments: solr-upgrade-gradle-7.5.1.patch > > Time Spent: 1h > Remaining Estimate: 0h > > To upgrade the build system to the latest gradle version, I ran the following > command after installing the gradle snap on my system: > {code:java} > gradle wrapper --gradle-version 7.5.1{code} > Then I had to update the version number to 7.5.1 in two files relative to the > root of the repo's working dir: > {code:java} > gradle/validation/check-environment.gradle > gradle/wrapper/gradle-wrapper.jar.version{code} > Doing that resulted in the attached patch. > I tested with "./gradlew precommit -Pvalidation.git.failOnModified=false" on > branch_9x and main with OpenJDK 17 after I did this upgrade. Both passed. > Does it need any more validation before committing to main? Is it something > that should be backported to branch_9x? > This gradle upgrade gets us Java 18 support, but not Java 19. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org