dsmiley commented on code in PR #1027:
URL: https://github.com/apache/solr/pull/1027#discussion_r978101253
##########
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##########
@@ -189,6 +205,7 @@ public void execute(CoreAdminHandler.CallInfo it) throws
Exception {
parentCore.getUpdateHandler().split(cmd);
if (it.handler.coreContainer.isZooKeeperAware()) {
+ log.trace("SplitOp: Create cloud descriptors for sub-shards of core:
{}", cname);
Review Comment:
core is redundant with MDC?
##########
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##########
@@ -145,6 +160,7 @@ public void execute(CoreAdminHandler.CallInfo it) throws
Exception {
}
if (pathsArr == null) {
+ log.trace("SplitOp: Create array of paths for sub-shards of core: {}",
cname);
Review Comment:
core is redundant with MDC?
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -163,6 +192,10 @@ public boolean split(ClusterState clusterState,
ZkNodeProps message, NamedList<O
RTimerTree t;
if (ccc.getCoreContainer().getNodeConfig().getMetricsConfig().isEnabled())
{
+ // 1. verify that there is enough space on disk to create sub-shards
+ log.info(
Review Comment:
Sometimes we don't check disk space, but we'd log and calculate timings.
Can you move the check that is currently inside checkDiskSpace() (which @heythm
added) to here so that we do neither if we don't actually check disk space?
##########
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##########
@@ -124,7 +136,10 @@ public void execute(CoreAdminHandler.CallInfo it) throws
Exception {
DocRouter router = null;
String routeFieldName = null;
+ // if in SolrCloud mode, get collection and shard names
if (it.handler.coreContainer.isZooKeeperAware()) {
+ log.trace(
+ "SplitOp: Determine which router is associated with the shard for
core: {}", cname);
Review Comment:
core is redundant with MDC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
