gerlowskija opened a new pull request, #1040:
URL: https://github.com/apache/solr/pull/1040

   # Description
   
   IgnoreLargeDocumentProcessorFactory only has a single way to handle 
documents that exceed its configurable size limit. The first violation throws a 
SolrException: in effect, short-circuiting any remaining documents in the 
"batch" and returning a 400 to the user.
   
   This is great for end users whose clients are built to handle the resulting 
400 response, and who can modify and resubmit the batch. But it's not ideal for 
every use-case, especially where "best-effort" indexing is good enough.
   
   # Solution
   
   This PR includes adding a new "permissive" mode of handling too-large 
documents to ILDPF. Under this new mode "too-large" documents will be logged 
(and not indexed), but won't cause the entire batch to be aborted/error-out.
   
   # Tests
   
   Tests and documentations are still needed.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to