janhoy commented on code in PR #1006: URL: https://github.com/apache/solr/pull/1006#discussion_r967896147
########## solr/bin/solr.in.sh: ########## @@ -280,4 +280,4 @@ # SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true" # The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable -# SOLR_MODULES=extraction,ltr Review Comment: The `bin/solr` script picks up `SOLR_OPTS` and other env.vars and pass them in as java sysprops on the cmdline. With `SOLR_MODULES` the Java code (https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/util/ModuleUtils.java#L59:L71) parses both sys.prop and env.var. But it obviouly only works if the var is exported. It's a pity we need to touch the `bin/solr` and `bin/solr.cmd` scripts for every variable we want to add support for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
