gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966259877
########## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.jersey; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * Base response-body POJO to be used by Jersey resources. + * + * <p>Contains fields common to all Solr API responses, particularly the 'responseHeader' and + * 'error' fields. + */ +public class SolrJerseyResponse implements JacksonReflectMapWriter { + + @JsonProperty("responseHeader") + public ResponseHeader responseHeader = new ResponseHeader(); + + @JsonProperty("error") + public ErrorInfo error; + + public static class ResponseHeader implements JacksonReflectMapWriter { Review Comment: Oh for sure - very much looking forward to seeing the strong-typing start to cut down on the NamedList/Map types that just absolutely abound across the codebase. How do you want to go forward on the rigidity issue? Is that something you'd be fine deferring to a follow-up PR, or would you like to see that fixed here? And either way, do you have a preference between the two potential solutions above? My preference would be to go the Jackson "additional properties" route on `ResponseHeader` - that'd allow us to at least keep strong typing for the few header entries we know about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
