gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965970532
########## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.jersey; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * Base response-body POJO to be used by Jersey resources. + * + * <p>Contains fields common to all Solr API responses, particularly the 'responseHeader' and + * 'error' fields. + */ +public class SolrJerseyResponse implements JacksonReflectMapWriter { + + @JsonProperty("responseHeader") + public ResponseHeader responseHeader = new ResponseHeader(); + + @JsonProperty("error") + public ErrorInfo error; + + public static class ResponseHeader implements JacksonReflectMapWriter { Review Comment: Oh, no, not at all. We've got a few options to handle cases like that: 1. Individual APIs (e.g. `/select`) can still choose to return `NamedList<Object>` or other loosely typed objects instead of the "stronger" SolrJerseyResponse. I think we should still strive to be strongly typed where-ever possible, but nothing about JAX-RS _requires_ this on any given API. Loose-typing might be best for `/select`, which as you point out can have any number of custom SearchComponents that modify the response. 2. Alternatively, there are ways to get some of this flexibility in a strongly-typed object. e.g. [Jackson's support for "additional properties"](https://stackoverflow.com/questions/39156293/jackson-deserialize-extra-fields-as-map). It might take some work to expand a solution of this sort out to xml, javabin, etc. but it seems do-able if this is an approach we like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
