dsmiley commented on PR #948:
URL: https://github.com/apache/solr/pull/948#issuecomment-1229095751

   I checked out the branch and applied some edits to the techproducts config 
and gave it a whirl. It seemed to work, even though I was only using one core 
so it wasn't some bigger comparison.  I also tried it with the prometheus 
exporter to ensure that the default config wasn't confused by this 
double-reporting.  AFAICT it was fine.
   
   Can you add something in the Solr Ref Guide so users know about this new 
nifty thing?  `metrics-reporting.adoc` in "Core (SolrCore) Registry" would be a 
decent place to include a little solrconfig code snippet of, say, the /select 
handler set up this way.  It could be added to 
`requesthandlers-searchcomponents.adoc` too but it would maybe be distracting 
there because metrics is a side concern and cross-cutting.
   
   This could go into CHANGES.txt under New Feature or Improvements; I tend to 
think the former here because there's a toggle/action to take.  Can you add 
that entry to?  Merge up with main first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to