gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r953822401
##########
solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java:
##########
@@ -75,6 +77,18 @@ public static boolean isAutoGeneratedConfigSet(String
configName) {
return configName != null &&
configName.endsWith(AUTOCREATED_CONFIGSET_SUFFIX);
}
+ private void squashIntoSolrResponse(SolrQueryResponse rsp, ReflectMapWriter
mw) {
+ Map<String, Object> myMap = new HashMap<>();
+ myMap = mw.toMap(myMap);
+ if (myMap.isEmpty()) {
+ log.info("Hmm, map is empty after writing in values from {}", mw);
+ }
+ for (String key : myMap.keySet()) {
+ log.info("Adding key={}, value={} to rsp", key, myMap.get(key));
Review Comment:
Agreed - I think I went through about a week ago and fixed this, though
maybe I missed some?
One thing that I find a little confusing about the Github UI is that it
doesn't hide conversations/comments like these after the code underlying them
has changed. I removed many instances of this a week or so ago, but you'd
never know from the landing page of this PR (if you miss the tiny 'Outdated'
indicator next to the filename in the snippet)
Oh well, there's no use complaining about Github's UI. I can always just
manually resolve all these conversations I guess...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
