cpoerschke opened a new pull request, #980:
URL: https://github.com/apache/solr/pull/980

   The `RealTimeGetComponent` uses `getLatestSchema` in 12 places and 
`getSchema` in 2 places.
   
   Intuitively I would expect `getSchema` to be used throughout since it as per 
https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/core/src/java/org/apache/solr/request/SolrQueryRequest.java#L86-L87
 that is snapshot at request creation and so logically cannot change during 
processing. But based on 12:2 ratio perhaps `getLatestSchema` is equally 
suitable?
   
   This pull request is to always use `getLatestSchema` _or to add clarifying 
comments_ w.r.t. why some places use one API and others use the other in the 
component.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to