ijioio commented on code in PR #931: URL: https://github.com/apache/solr/pull/931#discussion_r927752901
########## solr/core/src/test/org/apache/solr/handler/admin/CoreAdminHandlerActionTest.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.admin; + +import java.util.Map; +import org.apache.solr.SolrTestCaseJ4; +import org.apache.solr.common.SolrException; +import org.apache.solr.common.params.CoreAdminParams; +import org.apache.solr.common.util.NamedList; +import org.apache.solr.common.util.SimpleOrderedMap; +import org.apache.solr.handler.admin.CoreAdminHandler.CallInfo; +import org.apache.solr.handler.admin.CoreAdminHandler.CoreAdminOp; +import org.apache.solr.response.SolrQueryResponse; +import org.junit.BeforeClass; +import org.junit.Test; + +public class CoreAdminHandlerActionTest extends SolrTestCaseJ4 { + + private static CoreAdminHandler admin = null; + + @BeforeClass + public static void beforeClass() throws Exception { + + setupNoCoreTest(createTempDir(), null); + + admin = new CoreAdminHandler(h.getCoreContainer()); + + admin.registerCustomActions( + Map.of( + "action1", + new CoreAdminHandlerTestAction1(), + "action2", + new CoreAdminHandlerTestAction2())); + } + + @Test + @SuppressWarnings("unchecked") + public void testAction1() throws Exception { + + SolrQueryResponse response = new SolrQueryResponse(); + + admin.handleRequestBody(req(CoreAdminParams.ACTION, "action1"), response); + + Map<String, Object> actionResponse = ((NamedList<Object>) response.getResponse()).asMap(); + + assertTrue( + String.format( + "Action response should contain %s property", + CoreAdminHandlerTestAction1.PROPERTY_NAME), + actionResponse.containsKey(CoreAdminHandlerTestAction1.PROPERTY_NAME)); + assertEquals( + String.format( + "Action response should contain %s value for %s property", + CoreAdminHandlerTestAction1.PROPERTY_VALUE, CoreAdminHandlerTestAction1.PROPERTY_NAME), + CoreAdminHandlerTestAction1.PROPERTY_VALUE, + actionResponse.get(CoreAdminHandlerTestAction1.PROPERTY_NAME)); + } + + @Test + @SuppressWarnings("unchecked") + public void testAction2() throws Exception { + + SolrQueryResponse response = new SolrQueryResponse(); + + admin.handleRequestBody(req(CoreAdminParams.ACTION, "action2"), response); + + Map<String, Object> actionResponse = ((NamedList<Object>) response.getResponse()).asMap(); + + assertTrue( + String.format( + "Action response should contain %s property", + CoreAdminHandlerTestAction2.PROPERTY_NAME), + actionResponse.containsKey(CoreAdminHandlerTestAction2.PROPERTY_NAME)); + assertEquals( + String.format( + "Action response should contain %s value for %s property", + CoreAdminHandlerTestAction2.PROPERTY_VALUE, CoreAdminHandlerTestAction2.PROPERTY_NAME), + CoreAdminHandlerTestAction2.PROPERTY_VALUE, + actionResponse.get(CoreAdminHandlerTestAction2.PROPERTY_NAME)); + } + + @Test + public void testUnregisteredAction() throws Exception { + + SolrQueryResponse response = new SolrQueryResponse(); + + assertThrows( + "Attempt to execute unregistered action should throw SolrException", + SolrException.class, + () -> admin.handleRequestBody(req(CoreAdminParams.ACTION, "action3"), response)); + } Review Comment: Maybe there is a similar method already implemented in some utils class I can use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
