epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1190727394
Did a bit more work, and I think we should: - [ ] Eliminate all the `MatcherAssert.assertThat` and just have `assertThat()` - [ ] Eliminate all the `@Rule public ExpectedException` in favour of `assertThrows()` - [ ] Double check all the files for other asserts that can be simplified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org