gerlowskija commented on code in PR #452:
URL: https://github.com/apache/solr-operator/pull/452#discussion_r920269219
##########
api/v1beta1/solrcloud_types.go:
##########
@@ -576,8 +588,21 @@ const (
)
func (opts *ExternalAddressability) withDefaults(usesTLS bool) (changed bool) {
+ // TODO: Remove in v0.7.0
+ // If the deprecated IngressTLSTerminationSecret exists, use it to
default the new location of the value.
+ // If that location already exists, then merely remove the deprecated
option.
+ if opts.IngressTLSTerminationSecret != "" {
+ if !opts.HasIngressTLSTermination() {
+ opts.IngressTLSTermination = &SolrIngressTLSTermination{
+ TLSSecret: opts.IngressTLSTerminationSecret,
+ }
+ }
Review Comment:
[Q] If we receive a solrcloud that has both the deprecated
IngressTLSTerminationSecret and an IngressTLSTermination object, should we log
a warning or note the conflict in some other way?
I guess we wouldn't expect users to necessarily be checking the operator
logs for that sort of thing. So maybe there's no good way to surface this.
Just thinking aloud I guess...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
