cpoerschke commented on code in PR #900:
URL: https://github.com/apache/solr/pull/900#discussion_r895850091
##########
solr/core/src/test/org/apache/solr/core/BlobRepositoryCloudTest.java:
##########
@@ -49,7 +49,7 @@ public static void setupCluster() throws Exception {
HashMap<String, String> params = new HashMap<>();
CollectionAdminRequest.createCollection(CollectionAdminParams.SYSTEM_COLL,
null, 1, 1)
.process(cluster.getSolrClient());
- // test component will fail if it cant' find a blob with this data by this
name
+ // test component will fail if it can't' find a blob with this data by
this name
Review Comment:
```suggestion
// test component will fail if it can't find a blob with this data by
this name
```
##########
solr/core/src/test/org/apache/solr/core/CoreSorterTest.java:
##########
@@ -187,7 +187,7 @@ public void integrationTest() {
Collections.shuffle(myDescs, random());
List<CoreDescriptor> resultDescs = CoreSorter.sortCores(mockCC, myDescs);
- // map descriptors back to counts, removing consecutive duplicates
+ // map descriptors back to count's, removing consecutive duplicates
Review Comment:
```suggestion
// map descriptors back to counts, removing consecutive duplicates
```
##########
solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java:
##########
@@ -280,7 +280,8 @@ public void testPropFilePersistence() throws Exception {
"Failed corep4 should not have left a core.properties file around",
Files.exists(corePropFile));
- // Finally, just for yucks, let's determine that a this create path also
leaves a prop file.
+ // Finally, just for yucks, let's determine that this create path
operation also leaves a prop
+ // file.
Review Comment:
```suggestion
// Finally, let's determine that this create path operation also
leaves a prop file.
```
##########
solr/core/src/test/org/apache/solr/handler/TestSnapshotCoreBackup.java:
##########
@@ -146,7 +146,7 @@ public void testBackupBeforeFirstCommit() throws Exception {
assertU(adoc("id", "1")); // uncommitted
- { // second backup w/uncommited docs
+ { // second backup w/uncommitted docs
Review Comment:
```suggestion
{ // second backup with uncommitted docs
```
##########
solr/core/src/test/org/apache/solr/handler/component/StatsComponentTest.java:
##########
@@ -2021,26 +2021,26 @@ public void testHllOptions() throws Exception {
assertNull(HllOptions.parseHllOptions(params(), field_l));
assertNull(HllOptions.parseHllOptions(params("cardinality", "false"),
field_l));
- // sanity check, future proof against the HLL library changing stuff on us
+ // sanity check, future-proof against the HLL library changing stuff on us
Review Comment:
```suggestion
// check, future-proof against the HLL library changing stuff on us
```
##########
solr/core/src/test/org/apache/solr/handler/designer/ManagedSchemaDiffTest.java:
##########
@@ -40,7 +40,6 @@ public class ManagedSchemaDiffTest extends SolrCloudTestCase {
@BeforeClass
public static void createCluster() throws Exception {
- System.setProperty("managed.schema.mutable", "true");
Review Comment:
Not a typos or grammar change?
##########
solr/core/src/test/org/apache/solr/schema/TestSortableTextField.java:
##########
@@ -539,8 +539,8 @@ public void testUseDocValuesAsStored() {
}
/**
- * tests that a SortableTextField using KeywordTokenzier (w/docValues)
behaves exactly the same as
- * StrFields that it's copied to for quering and sorting
+ * tests that a SortableTextField using KeywordTokenizer (w/docValues)
behaves exactly the same as
Review Comment:
```suggestion
* tests that a SortableTextField using KeywordTokenizer (with docValues)
behaves exactly the same as
```
##########
solr/core/src/test/org/apache/solr/search/CurrencyRangeFacetCloudTest.java:
##########
@@ -96,13 +96,14 @@ public static void setupCluster() throws Exception {
assertEquals(0, cluster.getSolrClient().commit().getStatus());
}
- public void testSimpleRangeFacetsOfSymetricRates() throws Exception {
+ public void testSimpleRangeFacetsOfSymmetricRates() throws Exception {
for (boolean use_mincount : Arrays.asList(true, false)) {
// exchange rates relative to USD...
//
// for all of these permutations, the numDocs in each bucket that we get
back should be the
- // same (regardless of the any asymetric echanges ranges, or the
currency used for the 'gap')
+ // same (regardless of the any asymmetric exchanges ranges, or the
currency used for the
Review Comment:
```suggestion
// same (regardless of any asymmetric exchanges ranges, or the
currency used for the
```
##########
solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.java:
##########
@@ -214,7 +214,7 @@ public void merge(ResponseBuilder rb, ShardRequest sreq) {
continue;
}
- if (docs == null) { // could have been initialized in the shards info
block above
+ if (docs == null) { // could have been initialized in the shards' info
block above
Review Comment:
```suggestion
if (docs == null) { // could have been initialized in the
'shardInfo' block above
```
##########
solr/core/src/test/org/apache/solr/handler/TestSnapshotCoreBackup.java:
##########
@@ -393,7 +393,7 @@ public void
testDemoWhyBackupCodeShouldNeverUseIndexCommitFromSearcher() throws
// sanity check we are empty...
assertEquals(0L, (long) s.getIndexReader().numDocs());
- // sanity check this is the initial commit..
+ // sanity check this is the initial commit...
Review Comment:
```suggestion
// check this is the initial commit...
```
##########
solr/core/src/test/org/apache/solr/handler/TestIncrementalCoreBackup.java:
##########
@@ -91,15 +91,15 @@ public void testBackupWithDocsNotSearchable() throws
Exception {
public void testBackupBeforeFirstCommit() throws Exception {
- // even w/o a user sending any data, the SolrCore initialiation logic
should have automatically
+ // even w/o a user sending any data, the SolrCore initialization logic
should have automatically
Review Comment:
```suggestion
// even without a user sending any data, the SolrCore initialization
logic should have automatically
```
##########
solr/core/src/test/org/apache/solr/handler/TestSnapshotCoreBackup.java:
##########
@@ -88,15 +88,15 @@ public void testBackupWithDocsNotSearchable() throws
Exception {
public void testBackupBeforeFirstCommit() throws Exception {
- // even w/o a user sending any data, the SolrCore initialiation logic
should have automatically
+ // even w/o a user sending any data, the SolrCore initialization logic
should have automatically
Review Comment:
```suggestion
// even without a user sending any data, the SolrCore initialization
logic should have automatically
```
##########
solr/core/src/test/org/apache/solr/core/RAMDirectoryFactoryTest.java:
##########
@@ -59,7 +59,7 @@ private void dotestOpenSucceedForEmptyDir() throws
IOException {
Directory dir =
factory.get("/fake/path", DirContext.DEFAULT,
DirectoryFactory.LOCK_TYPE_SINGLE);
assertNotNull(
- "RAMDirectoryFactory should create RefCntRamDirectory even if the path
doen't lead "
+ "RAMDirectoryFactory should create RefCntRamDirectory even if the path
doesnt lead "
Review Comment:
```suggestion
"RAMDirectoryFactory should create RefCntRamDirectory even if the
path doesn't lead "
```
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/TestCollectionsAPIViaSolrCloudCluster.java:
##########
@@ -193,7 +193,7 @@ public void testCollectionCreateWithoutCoresThenDelete()
throws Exception {
// create collection
createCollection(collectionName,
CollectionHandlingUtils.CREATE_NODE_SET_EMPTY);
- // check the collection's corelessness
+ // check the collection's has no cores.
Review Comment:
```suggestion
// check the collection has no cores.
```
##########
solr/core/src/test/org/apache/solr/handler/TestIncrementalCoreBackup.java:
##########
@@ -147,7 +147,7 @@ public void testBackupBeforeFirstCommit() throws Exception {
assertU(adoc("id", "1")); // uncommitted
final ShardBackupId secondShardBackupId = new ShardBackupId("shard1", new
BackupId(1));
- { // second backup w/uncommited docs
+ { // second backup w/uncommitted docs
Review Comment:
```suggestion
{ // second backup with uncommitted docs
```
##########
solr/core/src/test/org/apache/solr/handler/TestStressThreadBackup.java:
##########
@@ -246,7 +246,7 @@ public void run() {
if (3 < namedSnapshots.size()
&& random().nextInt(3 + numBackupIters - i) <
random().nextInt(namedSnapshots.size())) {
- assert 0 < namedSnapshots.size() : "Someone broke the conditionl";
+ assert 0 < namedSnapshots.size() : "Someone broke the conditional";
Review Comment:
```suggestion
assert 0 < namedSnapshots.size() : "Something broke the
conditional";
```
##########
solr/core/src/test/org/apache/solr/handler/TestRequestId.java:
##########
@@ -45,14 +45,14 @@ public void testRequestId() {
try (LogListener reqLog = LogListener.info(SolrCore.class.getName() +
".Request")) {
- // Sanity check that the our MDC doesn't already have some sort of rid
set in it
+ // Sanity check that our MDC doesn't already have some sort of rid set
in it
Review Comment:
```suggestion
// Check that our MDC doesn't already have some sort of rid set in it
```
##########
solr/core/src/test/org/apache/solr/handler/component/StatsComponentTest.java:
##########
@@ -1557,7 +1557,7 @@ public void testIndividualStatLocalParams() throws
Exception {
kpre + "double[@name='min'][.='9.0']",
"count(" + kpre + "*)=2");
- // for stats that are true/false, sanity check false does it's job
+ // for stats that are true/false, sanity check false does its job
Review Comment:
```suggestion
// for stats that are true/false, check false does its job
```
##########
solr/core/src/test/org/apache/solr/handler/admin/V2CollectionsAPIMappingTest.java:
##########
@@ -275,7 +275,7 @@ public void testRestoreAllProperties() throws Exception {
assertEquals(123, v1Params.getPrimitiveInt(CoreAdminParams.BACKUP_ID));
assertEquals("requestTrackingId", v1Params.get(CommonAdminParams.ASYNC));
// NOTE: Unlike other v2 APIs that have a nested object for
collection-creation params,
- // restore's v1 equivalent for these properties doesn't have a
"create-collection." prefix.
+ // restores' v1 equivalent for these properties doesn't have a
"create-collection." prefix.
Review Comment:
```suggestion
// the restore API's v1 equivalent for these properties doesn't have a
"create-collection." prefix.
```
##########
solr/core/src/test/org/apache/solr/schema/CurrencyFieldTypeTest.java:
##########
@@ -393,7 +393,7 @@ public void testFunctionUsage() {
assertU(commit());
// direct value source usage, gets "raw" form od default currency
Review Comment:
```suggestion
// direct value source usage, gets "raw" form of default currency
```
##########
solr/core/src/test/org/apache/solr/rest/schema/TestBulkSchemaAPI.java:
##########
@@ -1469,7 +1469,8 @@ private static <T extends Similarity> void
assertFieldSimilarity(
Similarity mainSim = core.getLatestSchema().getSimilarity();
assertNotNull(mainSim);
- // sanity check simfac vs sim in use - also verify infom called on
simfac, otherwise exception
+ // sanity check simfac vs sim in use - also verify inform called on
simfac, otherwise
+ // exception
Review Comment:
```suggestion
// check simfac vs sim in use - also verify inform called on simfac,
otherwise exception
```
##########
solr/core/src/test/org/apache/solr/schema/CurrencyFieldTypeTest.java:
##########
@@ -650,7 +650,8 @@ public void testRangeFacet() {
"//lst[@name='xxx']/lst[@name='after' ]/long[@name='count'][.='1']",
"//lst[@name='xxx']/lst[@name='between']/long[@name='count'][.='4']");
- // NOTE: because of asymetric EUR exchange rate, these buckets are diff
then the similar looking
+ // NOTE: because of asymmetric EUR exchange rate, these buckets are diff
then the similar
Review Comment:
```suggestion
// NOTE: because of asymmetric EUR exchange rate, these buckets are diff
from the similar
```
##########
solr/core/src/test/org/apache/solr/schema/TestCollationField.java:
##########
@@ -36,7 +36,7 @@ public static void beforeClass() throws Exception {
// add some docs
assertU(adoc("id", "1", "text", "\u0633\u0627\u0628"));
assertU(adoc("id", "2", "text", "I WİLL USE TURKİSH CASING"));
- assertU(adoc("id", "3", "text", "ı will use turkish casıng"));
+ assertU(adoc("id", "3", "text", "ı will use turkish casing"));
Review Comment:
note-to-self bookmark for later: is this potentially a change in the
meaning/logic of the test?
##########
solr/core/src/test/org/apache/solr/handler/tagger/Tagger2Test.java:
##########
@@ -66,8 +66,8 @@ public void testLongestDominantRight() throws Exception {
assertTags("He lived in Clayton North Carolina", "in", "Clayton", "North
Carolina");
}
- // As of Lucene/Solr 4.9, StandardTokenizer never does this anymore
(reported to Lucene dev-list,
- // Jan 26th 2015. Honestly it's not particularly important to us but it
renders this test
+ // As of Lucene/Solr 4.9, StandardTokenizer never does this (reported to
Lucene dev-list),
+ // Jan 26th 2015. Honestly it's not particularly important to us, but it
renders this test
Review Comment:
```suggestion
// As of Lucene/Solr 4.9, StandardTokenizer never does this (reported to
Lucene dev-list,
// Jan 26th 2015). Honestly it's not particularly important to us, but it
renders this test
```
##########
solr/core/src/test/org/apache/solr/schema/SchemaVersionSpecificBehaviorTest.java:
##########
@@ -106,7 +106,7 @@ public void testVersionBehavior() throws Exception {
} else {
// for fields where the property is explicit, make sure
// we aren't getting a false negative because someone changed the
- // schema and we're inheriting from fieldType
+ // schema , and we're inheriting from fieldType
Review Comment:
```suggestion
// schema, and we're inheriting from fieldType
```
##########
solr/core/src/test/org/apache/solr/search/DelayingSearchComponent.java:
##########
@@ -37,12 +37,12 @@ public void process(ResponseBuilder rb) throws IOException {
TimeUnit.NANOSECONDS.convert(totalSleepMillis,
TimeUnit.MILLISECONDS);
final long startNanos = System.nanoTime();
try {
- // Thread.sleep() (and derivatives) are not garunteed to sleep the
full amount:
+ // Thread.sleep() (and derivatives) are not guaranteed to sleep the
full amount:
// "subject to the precision and accuracy of system timers and
schedulers."
// This is particularly problematic on Windows VMs, so we do a retry
loop
// to ensure we sleep a total of at least as long as requested
//
- // (Tests using this component do so explicitly to ensure 'timeAllowed'
+ // (Tests using this component are explicitly to ensure 'timeAllowed'
// has exceeded in order to get their expected results, we would
rather over-sleep
// then under sleep)
Review Comment:
```suggestion
// than under sleep)
```
##########
solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.java:
##########
@@ -516,7 +516,7 @@ public void merge(ResponseBuilder rb, ShardRequest sreq) {
continue;
}
- if (docs == null) { // could have been initialized in the shards info
block above
+ if (docs == null) { // could have been initialized in the shards' info
block above
Review Comment:
```suggestion
if (docs == null) { // could have been initialized in the
'shardInfo' block above
```
##########
solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java:
##########
@@ -655,7 +655,7 @@ public void testBlockJoin() throws Exception {
QParser.getParser("{!parent which=foo_s:parent}", req).getQuery());
}
- // sanity check multiple ways of specifing _nest_path_ prefixes
+ // sanity check multiple ways of specifying _nest_path_ prefixes
Review Comment:
```suggestion
// check multiple ways of specifying _nest_path_ prefixes
```
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedFacetPivotLargeTest.java:
##########
@@ -1558,7 +1558,7 @@ private void setupDistributedPivotFacetDocuments() throws
Exception {
SPECIAL);
// two really trivial documents, unrelated to the rest of the tests,
- // for the purpose of demoing the porblem with mincount=0
+ // for the purpose of demoing the problem with mincount=0
Review Comment:
```suggestion
// to demonstrate the problem with mincount=0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
