alessandrobenedetti commented on code in PR #872:
URL: https://github.com/apache/solr/pull/872#discussion_r879180441
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -500,7 +500,7 @@ protected int compare(int i, int j) {
// :TODO: would be simpler to always serialize every position of
SortField[]
if (type == SortField.Type.SCORE || type == SortField.Type.DOC)
continue;
- FieldComparator<?> comparator = sortField.getComparator(1, 0);
+ FieldComparator<?> comparator = sortField.getComparator(1, true);
Review Comment:
to elaborate
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -282,9 +282,9 @@ public VectorValues getVectorValues(String field) {
}
@Override
- public TopDocs searchNearestVectors(String field, float[] target, int k,
Bits acceptDocs)
- throws IOException {
- return null; // because not supported. Throw UOE?
+ public TopDocs searchNearestVectors(
+ String field, float[] target, int k, Bits acceptDocs, int visitedLimit)
throws IOException {
Review Comment:
acceptedDocs?
##########
solr/core/src/java/org/apache/solr/legacy/LegacyNumericRangeQuery.java:
##########
@@ -188,7 +188,7 @@ private LegacyNumericRangeQuery(
T max,
final boolean minInclusive,
final boolean maxInclusive) {
- super(field);
+ super(field, MultiTermQuery.CONSTANT_SCORE_REWRITE);
Review Comment:
elaborate
##########
solr/core/src/java/org/apache/solr/schema/RandomSortField.java:
##########
@@ -109,8 +109,8 @@ public void write(TextResponseWriter writer, String name,
IndexableField f) thro
new FieldComparatorSource() {
@Override
public FieldComparator<Integer> newComparator(
- final String fieldname, final int numHits, int sortPos, boolean
reversed) {
- return new SimpleFieldComparator<Integer>() {
+ final String fieldname, final int numHits, boolean enableSkipping,
boolean reversed) {
Review Comment:
elaborate
##########
solr/core/src/test/org/apache/solr/core/TestCodecSupport.java:
##########
@@ -19,13 +19,13 @@
import java.io.IOException;
import java.util.Map;
import org.apache.lucene.codecs.Codec;
-import org.apache.lucene.codecs.lucene90.Lucene90Codec.Mode;
import org.apache.lucene.codecs.lucene90.Lucene90StoredFieldsFormat;
Review Comment:
this stays 90? or 91?
##########
solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.java:
##########
@@ -420,7 +420,7 @@ protected int compare(int i, int j) {
}
if (comparator == null) {
- comparator = sortField.getComparator(1, 0);
+ comparator = sortField.getComparator(1, true);
Review Comment:
elaborate
##########
solr/licenses/asm-analysis-7.2.jar.sha1:
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review Comment:
elaborate
##########
solr/licenses/asm-tree-7.2.jar.sha1:
##########
@@ -0,0 +1 @@
+3a23cc36edaf8fc5a89cb100182758ccb5991487
Review Comment:
elaborate
##########
solr/core/src/java/org/apache/solr/schema/LatLonPointSpatialField.java:
##########
@@ -270,7 +270,7 @@ public DoubleValues getValues(LeafReaderContext ctx,
DoubleValues scores) throws
@SuppressWarnings("unchecked")
final FieldComparator<Double> comparator =
- (FieldComparator<Double>) getSortField(false).getComparator(1,
1);
+ (FieldComparator<Double>) getSortField(false).getComparator(1,
false);
Review Comment:
elaborate
##########
solr/core/src/java/org/apache/solr/search/join/ChildFieldValueSourceParser.java:
##########
@@ -131,8 +131,8 @@ public SortField getSortField(boolean reverse) {
childField.getName(), type, reverse, parentFilter, childFilter) {
@SuppressWarnings("unchecked")
@Override
- public FieldComparator<?> getComparator(int numHits, int sortPos) {
- final FieldComparator<?> comparator = super.getComparator(numHits,
sortPos);
+ public FieldComparator<?> getComparator(int numHits, boolean
enableSkipping) {
+ final FieldComparator<?> comparator = super.getComparator(numHits,
enableSkipping);
Review Comment:
elaborate
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -395,10 +395,6 @@ public SolrDocumentFetcher getDocFetcher() {
return docFetcher;
}
- List<LeafReaderContext> getLeafContexts() {
Review Comment:
elaborate
##########
solr/core/src/test/org/apache/solr/search/TestDocSet.java:
##########
@@ -367,7 +367,8 @@ public VectorValues getVectorValues(String field) {
}
@Override
- public TopDocs searchNearestVectors(String field, float[] target, int k,
Bits acceptDocs)
+ public TopDocs searchNearestVectors(
+ String field, float[] target, int k, Bits acceptDocs, int
visitedLimit)
Review Comment:
acceptedDocs?
##########
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java:
##########
@@ -3533,7 +3533,7 @@ public SortFieldsCompare(SortField[] sorts, int
initNumGroups) {
for (int clause = 0; clause < numClauses; clause++) {
SortField sf = sorts[clause];
// we only need one slot for every comparator
- fieldComparators[clause] = sf.getComparator(1, clause);
+ fieldComparators[clause] = sf.getComparator(1, clause == 0);
Review Comment:
elaborate
##########
solr/test-framework/src/java/org/apache/solr/schema/SortableBinaryField.java:
##########
@@ -73,7 +73,7 @@ public BinarySortField(final String field, final boolean
reverse) {
public FieldComparator.TermOrdValComparator newComparator(
final String fieldname,
final int numHits,
- final int sortPos,
+ final boolean enableSkipping,
Review Comment:
elaborate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
