[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535113#comment-17535113 ]
David Smiley commented on SOLR-14699: ------------------------------------- The JSON idea is alluring, even if it adds a bit more syntax. We could make up for this extra verbosity with dispensing with the {{webapp=/solr}} component because it's always this way (another issue). Also I don't get why params is wrapped with curly brackets; we should stop doing that (another issue). > Solr request logs should escape names, values > (SolrQueryResponse.getToLogAsString) > ---------------------------------------------------------------------------------- > > Key: SOLR-14699 > URL: https://issues.apache.org/jira/browse/SOLR-14699 > Project: Solr > Issue Type: Improvement > Components: logging > Reporter: David Smiley > Priority: Minor > > {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String > with simple space-separated pairs with name=value. However, it does no > escaping/encoding, and as-such a value might itself contain spaces and > equals. This is a problem if these logs are being parsed, and we'd like to > ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses > these logs. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org