risdenk commented on code in PR #848:
URL: https://github.com/apache/solr/pull/848#discussion_r868763428
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -241,6 +241,7 @@ private HttpClient createHttpClient(Builder builder) {
try {
httpClient.start();
} catch (Exception e) {
+ close(); // make sure we clean up
Review Comment:
Make sure we cleanup on a failed start. At least the executor could have
been created at this point. Other things might have been created as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
