risdenk commented on code in PR #818:
URL: https://github.com/apache/solr/pull/818#discussion_r866258661
##########
solr/core/src/java/org/apache/solr/handler/admin/RequestSyncShardOp.java:
##########
@@ -93,6 +93,7 @@ public void execute(CallInfo it) throws Exception {
}
} finally {
// no recoveryStrat close for now
+ // NOTE: try-with-resources is fine here; ok for `core` to be closed
before `syncStrategy`
if (syncStrategy != null) {
syncStrategy.close();
Review Comment:
shouldn't `syncStrategy` be a try w/ resources inside `core != null` around
line 58?
it seems weird at least looking at the change on github that syncStrategy is
even closed outside of where its used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
