risdenk commented on code in PR #829:
URL: https://github.com/apache/solr/pull/829#discussion_r863071464
##########
solr/core/src/test/org/apache/solr/schema/TestBulkSchemaConcurrent.java:
##########
@@ -145,46 +166,49 @@ private void invokeBulkAddCall(int seed,
ArrayList<String> errs) throws Exceptio
// get another node
Set<String> errmessages = new HashSet<>();
+ // don't close harness - gets closed at teardown
RestTestHarness harness = randomRestTestHarness(r);
- try {
- long startTime = System.nanoTime();
- long maxTimeoutMillis = 100000;
- while (TimeUnit.MILLISECONDS.convert(System.nanoTime() - startTime,
TimeUnit.NANOSECONDS)
- < maxTimeoutMillis) {
- errmessages.clear();
- @SuppressWarnings({"rawtypes"})
- Map m = getObj(harness, aField, "fields");
- if (m == null) errmessages.add(StrUtils.formatString("field {0} not
created", aField));
-
- m = getObj(harness, dynamicFldName, "dynamicFields");
- if (m == null)
- errmessages.add(StrUtils.formatString("dynamic field {0} not
created", dynamicFldName));
-
- @SuppressWarnings({"rawtypes"})
- List l = getSourceCopyFields(harness, aField);
- if (!checkCopyField(l, aField, dynamicCopyFldDest))
- errmessages.add(
- StrUtils.formatString(
- "CopyField source={0},dest={1} not created", aField,
dynamicCopyFldDest));
-
- m = getObj(harness, newFieldTypeName, "fieldTypes");
- if (m == null)
- errmessages.add(StrUtils.formatString("new type {0} not created",
newFieldTypeName));
-
- if (errmessages.isEmpty()) break;
-
- Thread.sleep(10);
+ long startTime = System.nanoTime();
Review Comment:
Addressed in b5d268ef8eb045c703fbcdef1e8987ebbbf061da
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
