[ https://issues.apache.org/jira/browse/SOLR-16176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530813#comment-17530813 ]
Michael Gibney edited comment on SOLR-16176 at 5/2/22 4:29 PM: --------------------------------------------------------------- Overrequest had previously been completely ignored for JSON facet terms {{method:enum}}, which led to different errors -- SOLR-14595 fixed these, but introduced an error where explicit overrequest was naively applied to limit, and could effectively turn an unlimited (limit:-1) request into a limited request (limit:n, n>=0) if both {{method:enum}} and explicit positive overrequest were specified. Probably an unusual combination "in the wild", but definitely a bug. [apache/solr#830|https://github.com/apache/solr/pull/830] fixes this oversight. was (Author: mgibney): Overrequest had previously been completely ignored for JSON facet terms {{method:enum}}, which led to different errors -- SOLR-14595 fixed these, but introduced an error where explicitly overrequest was naively applied to limit, and could effectively turn an unlimited (limit:-1) request into a limited request (limit:n, n>=0) if both {{method:enum}} and explicit positive overrequest were specified. Probably an unusual combination "in the wild", but definitely a bug. [apache/solr#830|https://github.com/apache/solr/pull/830] fixes this oversight. > Reproducing failure in TestCloudJSONFacetSKGEquiv.testRandom > ------------------------------------------------------------ > > Key: SOLR-16176 > URL: https://issues.apache.org/jira/browse/SOLR-16176 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 9.0 > Reporter: Gus Heck > Assignee: Michael Gibney > Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > When running the smoke tester for 9.0 RC4 I hit the following reproducible > failure: > ./gradlew :solr:core:test --tests > "org.apache.solr.search.facet.TestCloudJSONFacetSKGEquiv.testRandom" > -Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 > -Ptests.seed=C730F33909C71234 -Ptests.badapples=false > -Ptests.file.encoding=UTF-8 > > Offline discussion with [~magibney] indicates that he has confirmed that > although it is an edge case this reaches beyond SKG and was not present in 8 > hence blocker. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org