cpoerschke commented on code in PR #811:
URL: https://github.com/apache/solr/pull/811#discussion_r853082117
##########
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##########
@@ -456,5 +466,47 @@ protected Predicate<String> getFieldMatcher(String field) {
return NOT_REQUIRED_FIELD_MATCH_PREDICATE;
}
+
+ protected FieldHighlighter getFieldHighlighter(
+ String field, Query query, Set<Term> allTerms, int maxPassages) {
+
+ if (!"stripHTML".equals(params.getFieldParam(field,
HighlightParams.ENCODER, "simple"))) {
+ return super.getFieldHighlighter(field, query, allTerms, maxPassages);
+ }
+
+ UHComponents components = getHighlightComponents(field, query, allTerms);
+ OffsetSource offsetSource = getOptimizedOffsetSource(components);
+
+ return new FieldHighlighter(
+ field,
+ getOffsetStrategy(offsetSource, components),
+ new SplittingBreakIterator(getBreakIterator(field),
UnifiedHighlighter.MULTIVAL_SEP_CHAR),
+ getScorer(field),
+ maxPassages,
+ getMaxNoHighlightPassages(field),
+ getFormatter(field)) {
Review Comment:
If there was a `newFieldHighlighter` method as proposed in
https://github.com/apache/lucene/pull/821 then the various `get...` calls here
would not need duplicating when extending `FieldHighlighter` like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
