bursauxa opened a new pull request #784: URL: https://github.com/apache/solr/pull/784
https://issues.apache.org/jira/browse/SOLR-16138 # Description When reading from a `CloudSolrStream`, if all Solr cores are down, we receive an empty stream (EOF from the first `read()` operation). Instead, an exception should be thrown to represent that the Solr cluster is unreachable, even if the ZooKeeper cluster itself is reachable. # Solution Throw `IOException` in `CloudSolrStream.open()` when all shards or replicas are unavailable. # Tests I added a set of three tests to validate behaviors on badly behaving clusters. These tests are in their own suite, for reasons explained in the comments: we progressively damage the cluster, so it can not be run along "normal" tests. Tests 1 (empty collection) and 3 (cluster shutdown) were already working as expected, but I left them in for completeness. Test 2 (all nodes down) demonstrates the issue explained in Jira. On the current version of Solr, `getTuples(stream)` on line 89 would successfully return an empty list. With the changes made in this PR, it throws `IOException`, which the test asserts. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
