markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r826207829
##########
File path: solr/core/build.gradle
##########
@@ -90,6 +90,7 @@ dependencies {
implementation 'org.apache.httpcomponents:httpcore'
compileOnlyApi 'javax.servlet:javax.servlet-api'
+ compileOnlyApi 'org.eclipse.jetty.toolchain:jetty-servlet-api'
Review comment:
> I don't think we need this
I tried without it and it failed with a client/server using SSL mismatch
before putting this iteration up. I can take one more look at it.
> I think having both of these is incorrect?
I never actually added that myself, it did exist when I started, it was
removed in a rebase I did, and then, and if I remove it now,
analyzeClassesDependencies fails for me with (I'm digging around a bit, not
sure why it existed, or why it could be removed but then not in this issue):
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task
':solr:modules:jwt-auth:analyzeClassesDependencies'.
> Dependency analysis found issues.
usedUndeclaredArtifacts
- org.eclipse.jetty.toolchain:jetty-servlet-api:4.0.6@jar
Execution failed for task
':solr:modules:jwt-auth:analyzeClassesDependencies'.
> Dependency analysis found issues.
usedUndeclaredArtifacts
- org.eclipse.jetty.toolchain:jetty-servlet-api:4.0.6@jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
