dsmiley commented on a change in pull request #708: URL: https://github.com/apache/solr/pull/708#discussion_r825357518
########## File path: solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZkTestBase.java ########## @@ -1505,9 +1509,10 @@ private void testANewCollectionInOneInstance() throws Exception { SolrClient client3 = collectionClients.get(2); SolrClient client4 = collectionClients.get(3); - waitForRecoveriesToFinish( - oneInstanceCollection, getCommonCloudSolrClient().getZkStateReader(), false); - assertAllActive(oneInstanceCollection, getCommonCloudSolrClient().getZkStateReader()); + getCommonCloudSolrClient(); + waitForRecoveriesToFinish(oneInstanceCollection, ZkStateReader.from(cloudClient), false); + getCommonCloudSolrClient(); + assertAllActive(oneInstanceCollection, ZkStateReader.from(cloudClient)); Review comment: @haythemkh I don't know what you were doing here but I'll fix this in a minute and push a commit. Thanks @janhoy for reviewing so thoroughly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org