cpoerschke commented on a change in pull request #738:
URL: https://github.com/apache/solr/pull/738#discussion_r824939389
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -50,15 +50,7 @@ public MultiThreadedOCPTest() {
}
@Test
- public void test() throws Exception {
- testParallelCollectionAPICalls();
- testTaskExclusivity();
- testDeduplicationOfSubmittedTasks();
- testLongAndShortRunningParallelApiCalls();
- testFillWorkQueue();
Review comment:
Turning the five private methods into top-level tests means they could
run in different orders, so more realistic test coverage there as a side
effect, nice.
From a quick read of the tests, they don't look like one could cause side
effects that would change the baseline for the next tests. So changing order
should be fine.
Am less sure though on whether or not the tests could run in parallel now
then and if then they could interact with each other? The ones which create
collections, the collection names are specific to each test, so no problem
there at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
