[ 
https://issues.apache.org/jira/browse/SOLR-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503406#comment-17503406
 ] 

Jan Høydahl commented on SOLR-16089:
------------------------------------

Thanks for reporting and diving into the complex relationship between these 
data sources! I skimmed your patch and understand the issue. I did not attempt 
to understand every single line of the patch though, and I have not spun it up 
for a test.
I'm +1 to trust your thorough approach, so feel free to merge. But if you need 
a deeper peer reivew, let us know - I might find some time this week to take it 
for a spin and re-read the patch.

> DOWN replica causes missing data on Cloud>Nodes admin ui screen for unrelated 
> nodes
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-16089
>                 URL: https://issues.apache.org/jira/browse/SOLR-16089
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Admin UI
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-16089.patch, SOLR-16089.screenshot.png
>
>
> If a node is {{{}/live_nodes{}}}, but a replica hosted on that node is 
> {{DOWN}} ( or missing from the Metrics API response section for that node for 
> any other reason) this breaks a brittle assumption in the {{cloud.js}} logic 
> that generates the data structure used to power the 
> {{/solr/#/~cloud?view=nodes}}
> The current assumption is that _any_ replica found in the {{CLUSTERSTATUS}} 
> response, hosted on a live_node, will be found in the Metrics API response -- 
> when this is not true, the javascript throws a {{TypeError}} while looping 
> over the metrics API response, leaving the datastructure it was building 
> incomplete.
> This means that, depending on _where_ in the (effectively) random order that 
> the metrics API returns node details, all or some of the nodes visible on the 
> resulting admin UI screen will be missing data from the metrics API (most 
> notably in the Disk Usage column) depending on whether they came "after" the 
> node hosting the problematic replica.
> There is nothing obvious in the UI to indicate that a particular node/replica 
> is having a problem -- making it particularly hard to identify why columns 
> like Disk Usage are "blank"



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to