[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500825#comment-17500825
]
Jan Høydahl commented on SOLR-14401:
------------------------------------
Looks like your patch does NOT rename the prometheus keys being produced, only
the JSON produced by our metrics handler. That's good, else I'm afraid there
could be escaping issues in Grafana/prometheus.
However, the suffix leaks into prometheus as the {{searchHandler}} attribute. I
spun up the techproducts example and the exporter locally:
{code:java}
solr_metrics_core_query_p95_ms{category="QUERY",searchHandler="/select",core="techproducts",base_url="http://localhost:8983/solr",}
9.068646
solr_metrics_core_query_p95_ms{category="QUERY",searchHandler="/select[shard]",core="techproducts",base_url="http://localhost:8983/solr",}
0.0 {code}
I fear this may pollute the list of handlers in grafana, and that writing
(reg)expressions to filter them will be ugly due to the use of square brackets?
Did you consider another suffix without special chars?
I don't have a setup with operator, prom and grafana at hand, so not able to
immediately test.
> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
> Key: SOLR-14401
> URL: https://issues.apache.org/jira/browse/SOLR-14401
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed
> requests. However this was done for _all_ request handlers, even though it's
> mainly SearchHandler (and maybe one or two others?) where a distributed
> request is even possible. I refer to this as "metrics pollution" and it's a
> bad thing. It's more weight per handler (latency load & memory), more weight
> for Solr metrics responses, and it's also _suggestive_ that all registered
> handlers can have distributed requests when this is quite false, thus
> confusing people.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
