radu-gheorghe commented on pull request #714: URL: https://github.com/apache/solr/pull/714#issuecomment-1056399599
@epugh yes, I think an error would be nice. I mean, if I ask for highlighting and it can't be done, I expect an error. But I guess that's a separate issue. If `uniqueKey` isn't there, there's no trace of highlighting whatsoever. It's as if I didn't ask for it at all. And nothing in the logs (at least not with the default INFO level). I'm not sure how to change the wording to "highlighting only works if you have a uniqueKey" - I suppose that wouldn't be in the parenthesis I added, but maybe in another spot? To be, the current wording is OK, but we can definitely change it if you prefer something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
