[ https://issues.apache.org/jira/browse/SOLR-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497379#comment-17497379 ]
Eric Pugh commented on SOLR-16054: ---------------------------------- The documentation looks better, but I'm wondering if it really makes sense to limit the four choices? Especially since you can basically pick any of them, but remap them using the label to say whaterver? One client I work with has "candidate, stage, prod" for example. Another has "area51, dev, staging, production" ;-) What does the regex limitation give us? I checked how Rails handles having preset environments, and it ships with default configurations per environment set up in files like "development.yml, test.yml, production.yml", but nothing prevents you from defining your own environments, like "staging.yml". I wonder if we should be bending our thinking towards "here are the presets for Solr for environments, but nothing prevents you from making your own"? > Environment banner not working if environment is not dev or prod > ---------------------------------------------------------------- > > Key: SOLR-16054 > URL: https://issues.apache.org/jira/browse/SOLR-16054 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 8.11.1 > Reporter: Gaël Jourdan > Assignee: Jan Høydahl > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > When using the new system property to display a environment banner in Solr > UI, I cannot make it work. > > First attempt with `-Dsolr.environment=unknown,color=red` gives the following > error message on the UI: "Bad environment pattern: unknown,color=red". > > Second attempt with just `-Dsolr.environment=unknown` gives no error but no > banner appear nowhere. > > Third attempt using "dev" or "prod" do work. Thus I'm guessing there is a > list of allowed values? > I believe any value should be accepted as orgs can have various name for > their environment, especially with ephemeral environment. > Or at least the documentation should mention the list of allowed values. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org