risdenk commented on a change in pull request #696:
URL: https://github.com/apache/solr/pull/696#discussion_r813139363
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -64,6 +64,7 @@ allprojects { prj ->
'-Xep:ComparableType:OFF', // SolrTestCaseJ4.Doc and Fld are messy
'-Xep:AlmostJavadoc:OFF',
+ '-Xep:AlreadyChecked:OFF',
Review comment:
This check makes logic way more confusing in the few cases it came up.
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -104,9 +105,9 @@ allprojects { prj ->
'-Xep:MissingSummary:OFF',
'-Xep:MixedMutabilityReturnType:OFF',
'-Xep:ModifiedButNotUsed:OFF',
- '-Xep:MutableConstantField:OFF',
'-Xep:MutablePublicArray:OFF',
'-Xep:NarrowingCompoundAssignment:OFF',
+ '-Xep:NegativeCharLiteral:OFF',
Review comment:
Solr uses negative chars in a few places correctly and so this check
wasn't worth it.
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -104,9 +105,9 @@ allprojects { prj ->
'-Xep:MissingSummary:OFF',
'-Xep:MixedMutabilityReturnType:OFF',
'-Xep:ModifiedButNotUsed:OFF',
- '-Xep:MutableConstantField:OFF',
Review comment:
No longer a valid check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
