janhoy commented on a change in pull request #653:
URL: https://github.com/apache/solr/pull/653#discussion_r811249550
##########
File path: solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java
##########
@@ -563,28 +562,14 @@ public static boolean isMetaDataFile(String file) {
return file.charAt(0) == '.' && file.endsWith(".json");
}
- private void ensurePackageStoreDir(Path solrHome) {
- final File packageStoreDir = getPackageStoreDirPath(solrHome).toFile();
- if (!packageStoreDir.exists()) {
- try {
- final boolean created = packageStoreDir.mkdirs();
- if (!created) {
- log.warn("Unable to create [{}] directory in SOLR_HOME [{}].
Features requiring this directory may fail.", packageStoreDir, solrHome);
- }
- } catch (Exception e) {
- log.warn("Unable to create [{}] directory in SOLR_HOME [{}]. Features
requiring this directory may fail.", packageStoreDir, solrHome, e);
- }
- }
- }
-
public static synchronized Path getPackageStoreDirPath(Path solrHome) {
var path = solrHome.resolve(PackageStoreAPI.PACKAGESTORE_DIRECTORY);
if (!Files.exists(path)) {
try {
Files.createDirectories(path);
log.info("Created filestore folder {}", path);
} catch (IOException e) {
Review comment:
The policy already have this line
```
permission java.io.FilePermission "${solr.solr.home}",
"read,write,delete,readlink";
```
So that should be allowed -- if sysProp `solr.solr.home` is set to the same
location as `solrHome` in the test that failed (`TestManagedResourceStorage`)
that is, and I guess it is not...
Anyway, this PR avoids that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
