janhoy commented on pull request #670: URL: https://github.com/apache/solr/pull/670#issuecomment-1046054862
> Do we have standards or best practices regarding var? I know it's a new language feature, but I'm not in the habit of using it yet and don't have a great intuition about when it is appropriate and when it would reduce clarity? We don't have any coding standards like this. I'm used to it with Kotlin and it removes lots of boilerplate code. We should not yet do a cross-the-board update of the codebase, since we still may need to merge with 8.x for still another year. But I tend to do minor refactorings and improvements as I touch various code paths for other reasons. Sometimes I'm tempted to convert clunky code to streaming etc. But I agree that a separate PR is far better than unrelated changes in a feature or bugfix commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
