[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494994#comment-17494994
]
Kevin Risden edited comment on SOLR-14920 at 2/19/22, 4:10 PM:
---------------------------------------------------------------
I created linked tickets and PRs for a ton of the exceptions that were present
in spotless.gradle - specifically all the modules and prometheus-exporter.
* ":solr:modules:analytics" - SOLR-16032
* ":solr:modules:analysis-extras" - SOLR-16033
* ":solr:modules:clustering" - SOLR-16034
* ":solr:modules:extraction" - SOLR-16027
* ":solr:modules:gcs-repository" - SOLR-16026
* ":solr:modules:hadoop-auth" - SOLR-16024
* ":solr:modules:hdfs" - SOLR-16025
* ":solr:modules:langid" - SOLR-16028
* ":solr:modules:ltr" - SOLR-16029
* ":solr:modules:scripting" - SOLR-16030
* ":solr:prometheus-exporter" - SOLR-16035
* ":solr:core" - Not addressed
* ":solr:solrj" - Not addressed
* ":solr:solr-ref-guide" - Not addressed
* ":solr:test-framework" - Not addressed
Based on the conversation above I think this is what was agreed on getting
started with.
was (Author: risdenk):
I created linked tickets for a ton of the exceptions that were present -
specifically all the modules and prometheus-exporter.
* ":solr:modules:analytics" - SOLR-16032
* ":solr:modules:analysis-extras" - SOLR-16033
* ":solr:modules:clustering" - SOLR-16034
* ":solr:modules:extraction" - SOLR-16027
* ":solr:modules:gcs-repository" - SOLR-16026
* ":solr:modules:hadoop-auth" - SOLR-16024
* ":solr:modules:hdfs" - SOLR-16025
* ":solr:modules:langid" - SOLR-16028
* ":solr:modules:ltr" - SOLR-16029
* ":solr:modules:scripting" - SOLR-16030
* ":solr:prometheus-exporter" - SOLR-16035
* ":solr:core" - Not addressed
* ":solr:solrj" - Not addressed
* ":solr:solr-ref-guide" - Not addressed
* ":solr:test-framework" - Not addressed
Based on the conversation above I think this is what was agreed on getting
started with.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
