janhoy commented on a change in pull request #648:
URL: https://github.com/apache/solr/pull/648#discussion_r810509021
##########
File path: solr/core/src/test/org/apache/solr/servlet/HttpSolrCallCloudTest.java
##########
@@ -54,19 +54,28 @@ public static void setupCluster() throws Exception {
}
@Test
- public void test() throws Exception {
+ public void testCoreChosen() throws Exception {
assertCoreChosen(NUM_SHARD, new TestRequest("/collection1/update"));
assertCoreChosen(NUM_SHARD, new TestRequest("/collection1/update/json"));
assertCoreChosen(NUM_SHARD * REPLICA_FACTOR, new
TestRequest("/collection1/select"));
}
+ // https://issues.apache.org/jira/browse/SOLR-16019
+ @Test
+ public void testRequestParsingFails() throws Exception {
Review comment:
There is nothing wrong with `SolrRequestParsers.parseQueryString()`, it
throws an exception with 400 code, and that is what `testUrlParamParsing()`
tests.
It is what happens in the call chain when this exception occurs in the
constructor of HttpSolrCall that causes it to be wrapped in a 500 error to the
client, and to test that we need to invoke HttpSolrCall itself, as this PR
does, and proves that we now get a 400 response to the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
