dsmiley commented on a change in pull request #621: URL: https://github.com/apache/solr/pull/621#discussion_r806291185
########## File path: solr/modules/extraction/build.gradle ########## @@ -26,55 +26,18 @@ dependencies { implementation 'org.apache.lucene:lucene-core' implementation 'org.slf4j:slf4j-api' - // We export tika because other modules depend on it (and its submodules) Review comment: I don't think the Jar duplication is a big problem for us to make modules non-independent. ########## File path: solr/modules/extraction/build.gradle ########## @@ -26,55 +26,18 @@ dependencies { implementation 'org.apache.lucene:lucene-core' implementation 'org.slf4j:slf4j-api' - // We export tika because other modules depend on it (and its submodules) Review comment: Ok; makes sense for now. Hopefully this is documented for our users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org