risdenk commented on a change in pull request #635:
URL: https://github.com/apache/solr/pull/635#discussion_r806347554
##########
File path: solr/modules/s3-repository/build.gradle
##########
@@ -20,70 +20,70 @@ apply plugin: 'java-library'
description = 'S3 Repository'
dependencies {
- api project(':solr:core')
- implementation project(':solr:solrj')
+ api project(':solr:core')
+ implementation project(':solr:solrj')
- implementation 'org.apache.lucene:lucene-core'
+ implementation 'org.apache.lucene:lucene-core'
Review comment:
That is 100% a valid question and one I don't know the answer to. I
think there are a few other implementation -> api that we could make at `core`,
`test-framework` and maybe a few others that would make the downstream
consumers dependency declaration a bit cleaner. I could try it out, but didn't
want to make too many unnecessary changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
