risdenk commented on a change in pull request #621:
URL: https://github.com/apache/solr/pull/621#discussion_r806083202
##########
File path: solr/modules/extraction/build.gradle
##########
@@ -26,55 +26,18 @@ dependencies {
implementation 'org.apache.lucene:lucene-core'
implementation 'org.slf4j:slf4j-api'
- // We export tika because other modules depend on it (and its submodules)
Review comment:
So I looked into this more and it doesn't seem like there is clear
documentation on how this worked in Solr 8.x. It looks like there is an
implicit assumption that both `extraction` and `langid` would be on the Solr
classpath for `langid` to work with Tika.
Personally it feels way cleaner to me for each `module` to be independent
and therefore be included as standalone. This would end up with duplicate jars.
I think this is how packages would work though.
I understand the concern about not having duplicate jars in the distribution
due to size though. If we are that concerned about distribution size, wouldn't
it make more sense to have each contrib as a separate download instead of
trying to play tricks with these specific jars?
I played around with `api` vs `implementation` for this change - and it has
no effect on the `langid` module lib. The only way to remove the jar from
`langid` is to switch to `compileOnly` instead of `implementation` in the
`langid` module. I can make that change if that would be the preferred approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
