magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1034068134
re: inter-relationship between DocSetUtil and SolrIndexSearcher. I see the general issue you're concerned about, but if it's ok I'd like to leave `computeLiveDocs` stuff in SIS for this PR, and if/when work on refactoring stuff out as a separate issue? From my perspective, leaving `computeLiveDocs` in SIS for now really boils down to keeping the method `private`, with the goal of limiting the scopes from which that method is directly accessible -- or really I suppose more trying to ensure that there's exactly _one_ fundamental/canonical way to get liveDocSet, and that is directly via `SIS.getLiveDocSet()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
