[ https://issues.apache.org/jira/browse/SOLR-15972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489122#comment-17489122 ]
Jan Høydahl commented on SOLR-15972: ------------------------------------ If we leave it in the repo, we need to remove it from the src tarball during the git export, or after the git export but before the checksumming and signing. I think it is safest to avoid all compiled binary code in our source repo. But I'm no expert on this, see the conversation in the legal issue. If you CI can download from maven, can't you pull gradle-wrapper.jar from maven repo? > Remove gradle-wrapper.jar from source > ------------------------------------- > > Key: SOLR-15972 > URL: https://issues.apache.org/jira/browse/SOLR-15972 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Priority: Blocker > Fix For: 9.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Now that we use git export to produce the source release, there is > gradle-wrapper binary jar file in > [https://github.com/apache/solr/tree/main/gradle/wrapper] that we are not > allowed to include legally (LEGAL-570). Comparing with lucene, they do not > have the jar file in git and thus not in the source release either. > So I believe the solution is to remove the jar from Solr's git and let > "gradlew" script download it for you... > At first I hacked the smoketester to allow this one jar file, but that was > wrong, will revert that change... -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org